Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link behaviour #1407

Merged
merged 3 commits into from
Sep 20, 2023
Merged

fix link behaviour #1407

merged 3 commits into from
Sep 20, 2023

Conversation

k-ave
Copy link
Contributor

@k-ave k-ave commented Sep 18, 2023

At the moment if you click on a link while pressing the ctrl-key the current page plus a new tab will open with the requested page, which makes browsing multiple functions/tags a bit tiresome.

With the changes it should keep the browser behaviour without affecting Google-Stats.

However new URL(href) might say certain links are invalid like 'www.example.com' as there is no protocol and thus are not tracked.


[solved]
I did try to get grunt running, but had no luck so for now only one file.

Did following, but keep getting Missing script: "grunt" (installing grunt-cli, didn't work either as suggested in a few StackOverflow Questions)

cd builders/html/assets
npm install
npm run grunt

@k-ave
Copy link
Contributor Author

k-ave commented Sep 19, 2023

I was being a dummy, needed to just type grunt instead of npm run grunt. It also needed some additional packages for css/sass (ruby and sass) but afterwards it worked.

Added the additional files in a second commit.
I didn't change anything on the .css however since I needed to change the assetBundleVersion it created it's own file for it.

@zspitzer zspitzer merged commit 0a7476f into lucee:master Sep 20, 2023
4 checks passed
@zspitzer
Copy link
Member

looks good, thanks

@k-ave k-ave deleted the fix-link-behaviour branch September 30, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants