Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed minatar example #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yutaizhou
Copy link

examples/brax_minatar.ipynb imports a version of LogEnvState and LogWrapper from gymnax that does not support timestep logging, so the notebook does not run successfully.

This commit adds the newer definition of those two classes from purejaxrl/wrappers.py into the notebook to make it run successfully.

I only made this PR to raise awareness of the issue. I am not too familiar with the code base yet, so it's possible that I made a bunch of redundant imports.

Thank you for the wonderful blog post! To me, this is the "4 minute mile" equivalent of showing the cool possibilities of speeding up RL using jax :)

@luchris429
Copy link
Owner

Thanks Yutai! I'll get around back to this next week -- I don't think I can merge in the PR as-is since the notebook output hasn't been cleaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants