Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id-card #1296

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Add id-card #1296

merged 12 commits into from
Jul 31, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented May 19, 2023

Resolves #953

@vercel
Copy link

vercel bot commented May 19, 2023

@jguddas is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented May 19, 2023

Added or changed icons

icons/id-card.svg

Preview cohesion icons/square-check.svg
icons/id-card.svg
icons/subscript.svg
Preview stroke widths icons/id-card.svg
icons/id-card.svg
icons/id-card.svg
DPI Preview (24px) icons/id-card.svg
Icon X-rays icons/id-card.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const IdCardIcon = createLucideIcon('IdCard', [
  ["path",{"d":"M16 10h2"}],
  ["path",{"d":"M16 14h2"}],
  ["path",{"d":"M6.17 15a3 3 0 0 1 5.66 0"}],
  ["circle",{"cx":"9","cy":"11","r":"2"}],
  ["rect",{"x":"2","y":"5","width":"20","height":"14","rx":"2"}]
])

@karsa-mistmere
Copy link
Member

Maybe let's call this id-badge instead, although I'm not quite happy about the user shape still.

@ericfennis
Copy link
Member

@karsa-mistmere I get you, but at the same time I'm not sure if we will come up with an alternative.
But if you want to make more iterations on this, it's better if we close this one and continue in #953.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Jun 1, 2023

I still definitely want to make this work within the bounds of credit card, to be consistent:
image
image

I feel like taking into consideration discussions in #609, these should be able to work.

@github-actions github-actions bot added the Stale label Jul 2, 2023
@lucide-icons lucide-icons deleted a comment from github-actions bot Jul 10, 2023
@ericfennis
Copy link
Member

@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit?

@karsa-mistmere
Copy link
Member

@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit?

Sure: id-card

@github-actions github-actions bot removed the Stale label Aug 1, 2023
@ericfennis
Copy link
Member

LGTM @karsa-mistmere Go with that one?

@jguddas
Copy link
Member Author

jguddas commented Oct 6, 2023

Now we have a 1px gap violation between the head and the body.

@karsa-mistmere
Copy link
Member

Now we have a 1px gap violation between the head and the body.

Yes, but see #609 (comment)

icons/id-card.svg Outdated Show resolved Hide resolved
@jguddas
Copy link
Member Author

jguddas commented Oct 6, 2023

Now we have a 1px gap violation between the head and the body.

Yes, but see #609 (comment)

The violation is not really worth it, the whole icon hasn't been that hugely requested, and I'm fine with just closing this PR as well.

@ericfennis
Copy link
Member

I think we could make an exception for this one to accept this small violation.
Let's find a balance between making it recognizable, and consistent and between our guidelines. But with some, we could make exceptions. This icon has a valid usecase and is valuable in modern applications. It would be a shame if we couldn't do this because of a small violation.

I'm curious what you think of this.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 15, 2024
@github-actions github-actions bot added the Stale label Feb 19, 2024
@jguddas
Copy link
Member Author

jguddas commented Mar 28, 2024

New idea: icon - 2024-03-28T222422 505

icons
Open lucide studio

@karsa-mistmere
Copy link
Member

New idea: icon - 2024-03-28T222422 505

iconsOpen lucide studio

Pretty neat idea, I love it! Maybe it should be left to right though, I think that's a much more common layout.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, still not convinced with the design, to me looks a bit weird that the user icon is out of the boundaries of the card.. 🤔

@karsa-mistmere
Copy link
Member

Hmm, still not convinced with the design, to me looks a bit weird that the user icon is out of the boundaries of the card.. 🤔

Yeah, I kinda agree. How about this one? It's maybe a bit dense, but not that bad, I guess, we definitely have worse icons by density.

image

icons
Open lucide studio

@karsa-mistmere
Copy link
Member

Alternatively:

image

icons
Open lucide studio

@ericfennis
Copy link
Member

@karsa-mistmere The one you first posted seems to fit fine. On 100% scale it looks like a perfect id-card to me.

@jguddas
Copy link
Member Author

jguddas commented Jul 16, 2024

Alternatively:

image

iconsOpen lucide studio

I like this one, the first one not so much, the body has a bit of a weird gap on the lower left tho.

image

@karsa-mistmere
Copy link
Member

Like Eric, I prefer the first one:

image

iconsOpen lucide studio

@jguddas
Copy link
Member Author

jguddas commented Jul 20, 2024

Like Eric, I prefer the first one:

image
iconsOpen lucide studio

Feels to dense for me.

@karsa-mistmere
Copy link
Member

Like Eric, I prefer the first one:

image
iconsOpen lucide studio

Feels to dense for me.

A bit too dense for my liking as well, but I think it's still better than any alternatives so far and it's not extremely dense by any means.

@gyurielf
Copy link

Hello there!

Is there any chance to merge this ?
I would definitely fine with the latest version :)

@ericfennis ericfennis merged commit 1d5edc5 into lucide-icons:main Jul 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ID card icon
4 participants