Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sun-moon icon #1545

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Replace sun-moon icon #1545

merged 7 commits into from
Sep 6, 2023

Conversation

itsjavi
Copy link
Contributor

@itsjavi itsjavi commented Aug 31, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This version of the sun-moon icon is an alternate version with the moon + the shining lines of the sun.
You can see more clearly that is a moon, instead of 2 combined circles from the other version.

This icon represents a combination of the moon and sun icons more clearly.

image

Use cases: when you want to represent "OS preference" when it comes to dark-mode theme on a website.

Icon use case

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: sun, moon, sun-moon
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Added or changed icons

icons/sun-moon.svg

Preview cohesion icons/key-square.svg
icons/sun-moon.svg
icons/chevron-left.svg
Preview stroke widths icons/sun-moon.svg
icons/sun-moon.svg
icons/sun-moon.svg
DPI Preview (24px) icons/sun-moon.svg
Icon X-rays icons/sun-moon.svg

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, we don't add -2 icons, but I think replacing sun-moon with your version is a good idea.

icons/sun-moon-2.svg Outdated Show resolved Hide resolved
icons/sun-moon-2.json Outdated Show resolved Hide resolved
@itsjavi itsjavi changed the title Add sun-moon-2 icon Replace sun-moon icon Sep 4, 2023
icons/sun-moon.json Outdated Show resolved Hide resolved
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, good to go!

@ericfennis ericfennis merged commit 42f9cdc into lucide-icons:main Sep 6, 2023
3 checks passed
@itsjavi itsjavi deleted the add--sun-moon-2 branch September 6, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants