-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): changed search-code
icon
#1953
Conversation
Added or changed iconsWorks for: const FileCodeIcon = createLucideIcon('FileCode', [
["path",{"d":"M10 12.5 8 15l2 2.5"}],
["path",{"d":"m14 12.5 2 2.5-2 2.5"}],
["path",{"d":"M14 2v4a2 2 0 0 0 2 2h4"}],
["path",{"d":"M15 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V7z"}]
])
const MessageCircleCodeIcon = createLucideIcon('MessageCircleCode', [
["path",{"d":"M10 9.5 8 12l2 2.5"}],
["path",{"d":"m14 9.5 2 2.5-2 2.5"}],
["path",{"d":"M7.9 20A9 9 0 1 0 4 16.1L2 22z"}]
])
const MessageSquareCodeIcon = createLucideIcon('MessageSquareCode', [
["path",{"d":"M10 7.5 8 10l2 2.5"}],
["path",{"d":"m14 7.5 2 2.5-2 2.5"}],
["path",{"d":"M21 15a2 2 0 0 1-2 2H7l-4 4V5a2 2 0 0 1 2-2h14a2 2 0 0 1 2 2z"}]
])
const SearchCodeIcon = createLucideIcon('SearchCode', [
["path",{"d":"m13 13.5 2-2.5-2-2.5"}],
["path",{"d":"m21 21-4.3-4.3"}],
["path",{"d":"M9 8.5 7 11l2 2.5"}],
["circle",{"cx":"11","cy":"11","r":"8"}]
])
const SquareCodeIcon = createLucideIcon('SquareCode', [
["path",{"d":"M10 9.5 8 12l2 2.5"}],
["path",{"d":"m14 9.5 2 2.5-2 2.5"}],
["rect",{"width":"18","height":"18","x":"3","y":"3","rx":"2"}]
])
const SquareDashedBottomCodeIcon = createLucideIcon('SquareDashedBottomCode', [
["path",{"d":"M10 9.5 8 12l2 2.5"}],
["path",{"d":"M14 21h1"}],
["path",{"d":"m14 9.5 2 2.5-2 2.5"}],
["path",{"d":"M5 21a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h14a2 2 0 0 1 2 2v14a2 2 0 0 1-2 2"}],
["path",{"d":"M9 21h1"}]
]) |
I prefer the before. 🤔 |
It felt a bit cramped, but that's just a feel thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this adds half pixels. Not sure either
If you are happy with this I can update the rest of the code icons. |
dbc0a26
to
5cf755a
Compare
I ran my little magic command to apply changes accross icons automagically. magic(){old=$(mktemp) && pwd="$(pwd)" && git show main:icons/$1.svg >| "$old" && pushd ../lucide-studio && bun run magic.ts $old $pwd/icons/$1.svg $pwd/icons/*.svg && popd}
time magic search-code
# 2.65s user 0.39s system 107% cpu 2.825 total
git add --update icons/*-code.svg
git commit --message 'feat magic apply changes' |
5cf755a
to
9fb8894
Compare
@karsa-mistmere Yeah true, looks better on 100%. Angled paths always add a bit of half pixels. We should go for it. |
What is the purpose of this pull request?
Description
Increase size.
Before Submitting