Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed search-code icon #1953

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Mar 7, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Increase size.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Added or changed icons

icons/file-code.svgicons/message-circle-code.svgicons/message-square-code.svgicons/search-code.svgicons/square-code.svgicons/square-dashed-bottom-code.svg

Preview cohesion icons/square-plus.svgicons/square-x.svgicons/square-chevron-right.svgicons/square-function.svgicons/square-dashed-kanban.svgicons/square-pen.svg
icons/file-code.svgicons/message-circle-code.svgicons/message-square-code.svgicons/search-code.svgicons/square-code.svgicons/square-dashed-bottom-code.svg
icons/wind.svgicons/star-half.svgicons/file-audio-2.svgicons/cannabis.svgicons/test-tube-diagonal.svgicons/corner-right-down.svg
Preview stroke widths icons/file-code.svgicons/message-circle-code.svgicons/message-square-code.svgicons/search-code.svgicons/square-code.svgicons/square-dashed-bottom-code.svg
icons/file-code.svgicons/message-circle-code.svgicons/message-square-code.svgicons/search-code.svgicons/square-code.svgicons/square-dashed-bottom-code.svg
icons/file-code.svgicons/message-circle-code.svgicons/message-square-code.svgicons/search-code.svgicons/square-code.svgicons/square-dashed-bottom-code.svg
DPI Preview (24px) icons/file-code.svg icons/message-circle-code.svg icons/message-square-code.svg icons/search-code.svg icons/square-code.svg icons/square-dashed-bottom-code.svg
Icon X-rays icons/file-code.svg icons/message-circle-code.svg icons/message-square-code.svg icons/search-code.svg icons/square-code.svg icons/square-dashed-bottom-code.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const FileCodeIcon = createLucideIcon('FileCode', [
  ["path",{"d":"M10 12.5 8 15l2 2.5"}],
  ["path",{"d":"m14 12.5 2 2.5-2 2.5"}],
  ["path",{"d":"M14 2v4a2 2 0 0 0 2 2h4"}],
  ["path",{"d":"M15 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V7z"}]
])

const MessageCircleCodeIcon = createLucideIcon('MessageCircleCode', [
  ["path",{"d":"M10 9.5 8 12l2 2.5"}],
  ["path",{"d":"m14 9.5 2 2.5-2 2.5"}],
  ["path",{"d":"M7.9 20A9 9 0 1 0 4 16.1L2 22z"}]
])

const MessageSquareCodeIcon = createLucideIcon('MessageSquareCode', [
  ["path",{"d":"M10 7.5 8 10l2 2.5"}],
  ["path",{"d":"m14 7.5 2 2.5-2 2.5"}],
  ["path",{"d":"M21 15a2 2 0 0 1-2 2H7l-4 4V5a2 2 0 0 1 2-2h14a2 2 0 0 1 2 2z"}]
])

const SearchCodeIcon = createLucideIcon('SearchCode', [
  ["path",{"d":"m13 13.5 2-2.5-2-2.5"}],
  ["path",{"d":"m21 21-4.3-4.3"}],
  ["path",{"d":"M9 8.5 7 11l2 2.5"}],
  ["circle",{"cx":"11","cy":"11","r":"8"}]
])

const SquareCodeIcon = createLucideIcon('SquareCode', [
  ["path",{"d":"M10 9.5 8 12l2 2.5"}],
  ["path",{"d":"m14 9.5 2 2.5-2 2.5"}],
  ["rect",{"width":"18","height":"18","x":"3","y":"3","rx":"2"}]
])

const SquareDashedBottomCodeIcon = createLucideIcon('SquareDashedBottomCode', [
  ["path",{"d":"M10 9.5 8 12l2 2.5"}],
  ["path",{"d":"M14 21h1"}],
  ["path",{"d":"m14 9.5 2 2.5-2 2.5"}],
  ["path",{"d":"M5 21a2 2 0 0 1-2-2V5a2 2 0 0 1 2-2h14a2 2 0 0 1 2 2v14a2 2 0 0 1-2 2"}],
  ["path",{"d":"M9 21h1"}]
])

@karsa-mistmere
Copy link
Member

I prefer the before. 🤔

@jguddas
Copy link
Member Author

jguddas commented Mar 7, 2024

I prefer the before. 🤔

It felt a bit cramped, but that's just a feel thing.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this adds half pixels. Not sure either

@karsa-mistmere
Copy link
Member

Hmm, this adds half pixels. Not sure either

That was also my issue, but to be fair, it kinda looks better at 100%
image

Still, should we update this, a lot of other icons should be updated to match square-code, file-code, message-code etc etc etc

@jguddas
Copy link
Member Author

jguddas commented Mar 16, 2024

If you are happy with this I can update the rest of the code icons.

@jguddas jguddas force-pushed the studio/search-code branch 2 times, most recently from dbc0a26 to 5cf755a Compare March 16, 2024 22:49
@jguddas
Copy link
Member Author

jguddas commented Mar 16, 2024

I ran my little magic command to apply changes accross icons automagically.

magic(){old=$(mktemp) && pwd="$(pwd)" && git show main:icons/$1.svg >| "$old" && pushd ../lucide-studio && bun run magic.ts $old $pwd/icons/$1.svg $pwd/icons/*.svg && popd}

time magic search-code
#   2.65s user 0.39s system 107% cpu 2.825 total

git add --update icons/*-code.svg
git commit --message 'feat magic apply changes'

@ericfennis
Copy link
Member

@karsa-mistmere Yeah true, looks better on 100%. Angled paths always add a bit of half pixels. We should go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants