Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add map-pin-house icon #2337

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat(icons): add map-pin-house icon #2337

merged 1 commit into from
Aug 2, 2024

Conversation

karsa-mistmere
Copy link
Member

@karsa-mistmere karsa-mistmere commented Jul 29, 2024

closes #1476

What is the purpose of this pull request?

  • New Icon

Description

Icon use case

  • Indicating a property location
  • Marking a (home) address on a map application
  • Representing a saved or favorite place in a navigation app
  • Showing the location of a house in a local community map
  • Displaying the location of a home on social media check-ins
  • Marking the headquarters of a business

Alternative icon designs

see #1476

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • I've based them on the following Lucide icons: map-pin and partially house

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jul 29, 2024
Copy link

Added or changed icons

icons/map-pin-house.svg

Preview cohesion icons/square-chevron-up.svg
icons/map-pin-house.svg
icons/ear.svg
Preview stroke widths icons/map-pin-house.svg
icons/map-pin-house.svg
icons/map-pin-house.svg
DPI Preview (24px) icons/map-pin-house.svg
Icon X-rays icons/map-pin-house.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const MapPinHouseIcon = createLucideIcon('MapPinHouse', [
  ["path",{"d":"M15 22a1 1 0 0 1-1-1v-4a1 1 0 0 1 .445-.832l3-2a1 1 0 0 1 1.11 0l3 2A1 1 0 0 1 22 17v4a1 1 0 0 1-1 1z"}],
  ["path",{"d":"M18 10a8 8 0 0 0-16 0c0 4.993 5.539 10.193 7.399 11.799a1 1 0 0 0 .601.2"}],
  ["path",{"d":"M18 22v-3"}],
  ["circle",{"cx":"10","cy":"10","r":"3"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Nice work @karsa-mistmere !

@ericfennis ericfennis merged commit 3cf6735 into main Aug 2, 2024
8 checks passed
@ericfennis ericfennis deleted the icon/map-pin-house branch August 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map-pin-home
3 participants