Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing deprecation warning for LinkedIn logo #2466

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

pedrowindisch
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update (maybe?)
  • Other:

Description

The LinkedIn icon currently lacks the deprecation warning present on most other brand icons.

To prevent users from being caught off guard, I've added the same deprecation warning to this icon. I wasn't aware that brand icons were being deprecated until I added another icon to my app, which did display the warning.

Before Submitting

@github-actions github-actions bot added the 🫧 metadata Improved metadata label Sep 16, 2024
@pedrowindisch pedrowindisch changed the title fix: missing deprecation warning for LinkedIn logo fix: add missing deprecation warning for LinkedIn logo Sep 16, 2024
Copy link
Member

@karsa-mistmere karsa-mistmere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch!

@karsa-mistmere karsa-mistmere merged commit d497689 into lucide-icons:main Oct 2, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants