Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed shopping-bag icon #2483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 19, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Arcified icon.

Before Submitting

@jguddas jguddas marked this pull request as ready for review September 19, 2024 19:04
@github-actions github-actions bot added the 🎨 icon About new icons label Sep 19, 2024
Copy link

Added or changed icons

icons/shopping-bag.svg

Preview cohesion icons/key-square.svg
icons/shopping-bag.svg
icons/cigarette-off.svg
Preview stroke widths icons/shopping-bag.svg
icons/shopping-bag.svg
icons/shopping-bag.svg
DPI Preview (24px) icons/shopping-bag.svg
Icon X-rays icons/shopping-bag.svg
Icon Diffs icons/shopping-bag.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ShoppingBagIcon = createLucideIcon('ShoppingBag', [
  ["path",{"d":"M16 10a4 4 0 0 1-8 0"}],
  ["path",{"d":"M3.103 6.034h17.794"}],
  ["path",{"d":"M3.4 5.467a2 2 0 0 0-.4 1.2V20a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2V6.667a2 2 0 0 0-.4-1.2l-2-2.667A2 2 0 0 0 17 2H7a2 2 0 0 0-1.6.8z"}]
])

@karsa-mistmere
Copy link
Member

Throwing this complete redesign in here, tbh, I'm not a fan of our current shopping bag icon:

icons
Open lucide studio

@jguddas
Copy link
Member Author

jguddas commented Sep 21, 2024

The current version is also a bit big, I don't like it when it is smaller tho, I feel like it needs to be taller than it is wide.
icons
Open lucide studio

@karsa-mistmere
Copy link
Member

The current version is also a bit big, I don't like it when it is smaller tho, I feel like it needs to be taller than it is wide.

I kind agree, which is exactly why the one I posted – while the base shape is almost square – I think has a kind of "illusion of narrowness" because of the extra handle.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants