Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): Update trash icon path order #2491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dotspencer
Copy link

@dotspencer dotspencer commented Sep 23, 2024

What is the purpose of this pull request?

  • Bug fix

Description

Updates path order on trash and trash-2 to preserve outline when using fill. The fill on the open path was overlapping the top line. Fix was the simply move the top line to be the last child in the svg.

Trash before / after

Trash 2 before / after

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Added or changed icons

icons/trash-2.svgicons/trash.svg

Preview cohesion icons/square-code.svgicons/square-menu.svg
icons/trash-2.svgicons/trash.svg
icons/ticket-x.svgicons/boxes.svg
Preview stroke widths icons/trash-2.svgicons/trash.svg
icons/trash-2.svgicons/trash.svg
icons/trash-2.svgicons/trash.svg
DPI Preview (24px) icons/trash-2.svg icons/trash.svg
Icon X-rays icons/trash-2.svg icons/trash.svg
Icon Diffs icons/trash-2.svg icons/trash.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const Trash2Icon = createLucideIcon('Trash2', [
  ["path",{"d":"M19 6v14c0 1-1 2-2 2H7c-1 0-2-1-2-2V6"}],
  ["path",{"d":"M8 6V4c0-1 1-2 2-2h4c1 0 2 1 2 2v2"}],
  ["line",{"x1":"10","x2":"10","y1":"11","y2":"17"}],
  ["line",{"x1":"14","x2":"14","y1":"11","y2":"17"}],
  ["path",{"d":"M3 6h18"}]
])

const TrashIcon = createLucideIcon('Trash', [
  ["path",{"d":"M19 6v14c0 1-1 2-2 2H7c-1 0-2-1-2-2V6"}],
  ["path",{"d":"M8 6V4c0-1 1-2 2-2h4c1 0 2 1 2 2v2"}],
  ["path",{"d":"M3 6h18"}]
])

@jguddas
Copy link
Member

jguddas commented Sep 24, 2024

Sorry, we do not support fills and mighty change the path order at any time.

@dotspencer
Copy link
Author

@jguddas Unfortunate, ok

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants