Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed person-standing icon #2496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 26, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Redesigned the person-standing icon.

  • Adjusted size.
  • Added roundness.
  • Increased head size to remove gap violation.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Added or changed icons

icons/person-standing.svg

Preview cohesion icons/square-x.svg
icons/person-standing.svg
icons/egg-fried.svg
Preview stroke widths icons/person-standing.svg
icons/person-standing.svg
icons/person-standing.svg
DPI Preview (24px) icons/person-standing.svg
Icon X-rays icons/person-standing.svg
Icon Diffs icons/person-standing.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PersonStandingIcon = createLucideIcon('PersonStanding', [
  ["path",{"d":"M15.55 17h-7.1"}],
  ["path",{"d":"m16 22-1.012-11.268a3 3 0 0 0-5.976 0L8 22"}],
  ["path",{"d":"m21 9-6.012 1.732"}],
  ["path",{"d":"M9.012 10.732 3 9"}],
  ["circle",{"cx":"12","cy":"5","r":"3"}]
])

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Sep 26, 2024

image

Sorry, but I'm afraid this design is still a thumbs down from me. 🫣

(Plus, for a redesign, we'd also have to take into consideration compatibility with #609 )

@jguddas
Copy link
Member Author

jguddas commented Sep 26, 2024

I think it's more lucidy and has fewer guideline violation, it doesn't need to be perfect.

@jamiemlaw
Copy link
Contributor

For reference, GitHub's accessibility icon uses this kind of design:

image

icons
Open lucide studio

And a very crude representation of that style of figure walking:

icons
Open lucide studio

@jamiemlaw
Copy link
Contributor

jamiemlaw commented Sep 26, 2024

A few more ideas for consideration, just to have in the backlog:

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

icons
Open lucide studio

Obviously not the last one!

@jguddas
Copy link
Member Author

jguddas commented Sep 26, 2024

What about a wheelchair user and cyclist variant?

@jamiemlaw
Copy link
Contributor

For the wheelchair, I'm thinking something like this but it might require some extra work.

icons
Open lucide studio

There would also need to be a version for a wheelchair user on the move.

For the cyclist, I've seen some of the past attempts by other users in this repo. Here's where my head's currently at:

image

@jguddas jguddas mentioned this pull request Oct 5, 2024
23 tasks
@jamiemlaw jamiemlaw mentioned this pull request Oct 9, 2024
5 tasks
@karsa-mistmere
Copy link
Member

The current primary (intended) use case of this icon is to represent accessibility, this redesign does not fulfil this use case:
image

As such, I'm against it.

@jguddas
Copy link
Member Author

jguddas commented Oct 9, 2024

The current primary (intended) use case of this icon is to represent accessibility, this redesign does not fulfil this use case: image

As such, I'm against it.

Why does it not fulfill that use case, it's literally used that way on GitHub?

image

But yes, the accessibility icon in a lot of places is based on Vitruvian Man.
I'm not opposed to adding a circle-person-standing, I'm actually quite in favor #921, hehe.

@jamiemlaw
Copy link
Contributor

I'm torn on the issue.

Some icon designs look much better to me in the stick figure style, e.g. wheelchair user, cyclist; but others like standing, walking and running feel way more "Lucide"-y in the fatter outline style.

In any case, here are some potentially suitable stick figure designs, with ever-increasing leg gap. I'm favouring the last two.

icons icons icons icons icons

Or taller still?

icons icons

@jguddas
Copy link
Member Author

jguddas commented Oct 15, 2024

I love the GitHub-y version, what I struggle with is consistency, how are we gonna manage to update the cyclist and wheelchair-user to feel just as awesome?

@jguddas
Copy link
Member Author

jguddas commented Oct 15, 2024

I'm torn on the issue.

Some icon designs look much better to me in the stick figure style, e.g. wheelchair user, cyclist; but others like standing, walking and running feel way more "Lucide"-y in the fatter outline style.

In any case, here are some potentially suitable stick figure designs, with ever-increasing leg gap. I'm favouring the last two.

icons icons icons icons icons

Or taller still?

icons icons

The stick figure version also feels a bit male to me, while the GitHub-y version feels quite a bit more gender neutral.

@jguddas
Copy link
Member Author

jguddas commented Nov 1, 2024

I love this GitHub-y version and want us to merge this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants