-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): changed person-standing
icon
#2496
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const PersonStandingIcon = createLucideIcon('PersonStanding', [
["path",{"d":"M15.55 17h-7.1"}],
["path",{"d":"m16 22-1.012-11.268a3 3 0 0 0-5.976 0L8 22"}],
["path",{"d":"m21 9-6.012 1.732"}],
["path",{"d":"M9.012 10.732 3 9"}],
["circle",{"cx":"12","cy":"5","r":"3"}]
]) |
Sorry, but I'm afraid this design is still a thumbs down from me. 🫣 (Plus, for a redesign, we'd also have to take into consideration compatibility with #609 ) |
I think it's more lucidy and has fewer guideline violation, it doesn't need to be perfect. |
For reference, GitHub's accessibility icon uses this kind of design: And a very crude representation of that style of figure walking: |
A few more ideas for consideration, just to have in the backlog: Obviously not the last one! |
What about a wheelchair user and cyclist variant? |
Why does it not fulfill that use case, it's literally used that way on GitHub? But yes, the accessibility icon in a lot of places is based on Vitruvian Man. |
I'm torn on the issue. Some icon designs look much better to me in the stick figure style, e.g. wheelchair user, cyclist; but others like standing, walking and running feel way more "Lucide"-y in the fatter outline style. In any case, here are some potentially suitable stick figure designs, with ever-increasing leg gap. I'm favouring the last two. Or taller still? |
I love the GitHub-y version, what I struggle with is consistency, how are we gonna manage to update the cyclist and wheelchair-user to feel just as awesome? |
The stick figure version also feels a bit male to me, while the GitHub-y version feels quite a bit more gender neutral. |
I love this GitHub-y version and want us to merge this 🙏 |
What is the purpose of this pull request?
Description
Redesigned the
person-standing
icon.Before Submitting