-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added request-review workflow #2502
base: main
Are you sure you want to change the base?
Conversation
Hmm, I think this might actually not work as intended, I can't add most people, even by hand. |
Hmm not sure if we want this. But I like the idea. For old icons colebemis is listed as a contributor. Since he is not really involved in this project. Not sure if he should be invited. |
We could also mention them in the PR comment. Another alternative is automatically generated code owners, not sure how that could work tho. |
Hmm no I think we can keep this idea. But we should add an if statement for |
I don't think he will get added by this workflow, I think it will ignore him
It will not add him, I'm not sure what the requirements are, but this is the output I get:
|
@jguddas Thanks for checking! Maybe @karsa-mistmere wants to leave a review here as well? |
What is the purpose of this pull request?
Description
Adds all the contributor to the icon you are changing as reviewers.
Before Submitting