Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(shared): added mergeClasses tests #2503

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 28, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: Tests

Description

Checking that we don't have trailing spaces and such.

Related to #2498

Before Submitting

@github-actions github-actions bot added the 📦 dependencies Pull requests that update a dependency file label Sep 28, 2024
@ericfennis
Copy link
Member

Awesome work @jguddas !

We need also adding a gh workflow for this to check when PRS are created.

@jguddas
Copy link
Member Author

jguddas commented Oct 1, 2024

Awesome work @jguddas !

We need also adding a gh workflow for this to check when PRS are created.

I would prefer a pnpm run --filter=[$target...HEAD] test that runs over only changed workspaces, that would reduce the CI cost and I don't think we have ever cought anything with those CI Checks anyway so it's pretty safe.

@ericfennis
Copy link
Member

Yeah true, we can add it later.

@ericfennis ericfennis merged commit e1202b5 into main Oct 8, 2024
21 checks passed
@ericfennis ericfennis deleted the tests/shared-added-mergeClass-tests branch October 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants