-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): rename box-select
to square-dashed
#2506
Conversation
Added or changed iconsIcons as codeWorks for: const SquareDashedIcon = createLucideIcon('SquareDashed', [
["path",{"d":"M5 3a2 2 0 0 0-2 2"}],
["path",{"d":"M19 3a2 2 0 0 1 2 2"}],
["path",{"d":"M21 19a2 2 0 0 1-2 2"}],
["path",{"d":"M5 21a2 2 0 0 1-2-2"}],
["path",{"d":"M9 3h1"}],
["path",{"d":"M9 21h1"}],
["path",{"d":"M14 3h1"}],
["path",{"d":"M14 21h1"}],
["path",{"d":"M3 9v1"}],
["path",{"d":"M21 9v1"}],
["path",{"d":"M3 14v1"}],
["path",{"d":"M21 14v1"}]
]) |
Added or changed iconsIcons as codeWorks for: const SquareDashedIcon = createLucideIcon('SquareDashed', [
["path",{"d":"M5 3a2 2 0 0 0-2 2"}],
["path",{"d":"M19 3a2 2 0 0 1 2 2"}],
["path",{"d":"M21 19a2 2 0 0 1-2 2"}],
["path",{"d":"M5 21a2 2 0 0 1-2-2"}],
["path",{"d":"M9 3h1"}],
["path",{"d":"M9 21h1"}],
["path",{"d":"M14 3h1"}],
["path",{"d":"M14 21h1"}],
["path",{"d":"M3 9v1"}],
["path",{"d":"M21 9v1"}],
["path",{"d":"M3 14v1"}],
["path",{"d":"M21 14v1"}]
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add the alias field for backwards compatibility.
How do I? I haven't read any ‘alias’ or same thing in the documentation. Would you point out similar icons that renamed like |
You can search the code it's in the .json, I'm on the phone right now, that's the best I can do. You can also check the icon schema. |
I already added an aliases. |
What is the purpose of this pull request?
Description
The icon named
box-select
violates the naming convention as outlined in Naming convention in Lucide's design principle #3. Instead of usingbox-select
, we will rename it tosquare-dashed
, following the convention used in names likesquare-dashed-mouse-pointer
.Before Submitting