Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add gender icons #2607

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jamiemlaw
Copy link
Contributor

@jamiemlaw jamiemlaw commented Nov 12, 2024

closes #560

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds a variety of gender icons:

  • mars (male)
  • venus (female)
  • venus-and-mars (intersex, androgynous, hermaphrodite)
  • mars-stroke (androgyne, transgender, possibly "other gender")
  • transgender (transgender, gender inclusivity)
  • nonbinary
  • circle-small (genderless)
  • neuter

Care has gone into submitting the fewest number of icons to be gender-inclusive, without being overwhelming. It is important to note that these icons represent genders, not gender identities; the latter are too numerous, and too specific for this icon library. This PR also does not include sexual orientations, which, while similar to gender, are a distinct concept, and therefore out of scope. If there is demand, it can be raised separately.

Other icons that are intentionally not included:

  • mercury (historically used for intersex, but since replaced by venus-and-mars)
  • mars-stroke-right and mars-stroke-up (too similar to mars-stroke in design, not referenced in the Wikipedia article for gender symbols)

Icon use case

  • For all icons: personal profiles
  • For mars, venus and venus-and-mars: the biological sex of a person, animal or plant
  • For mars, venus and neuter: grammatical gender of a noun
  • For venus-and-mars, mars-stroke, nonbinary, circle-small, transgender, neuter: ways to express a person's gender beyond male and female
  • For transgender: to denote gender inclusivity (all genders)
  • For circle-small: a bullet point

Alternative icon designs

image

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Added or changed icons

icons/circle-small.svgicons/mars-stroke.svgicons/mars.svgicons/non-binary.svgicons/transgender.svgicons/venus-and-mars.svgicons/venus.svg

Preview cohesion icons/square-check-big.svgicons/square-kanban.svgicons/message-square-warning.svgicons/messages-square.svgicons/square-arrow-up-left.svgicons/square-activity.svgicons/square-user.svg
icons/circle-small.svgicons/mars-stroke.svgicons/mars.svgicons/non-binary.svgicons/transgender.svgicons/venus-and-mars.svgicons/venus.svg
icons/vibrate.svgicons/cannabis.svgicons/align-horizontal-justify-end.svgicons/message-square-dot.svgicons/bookmark-x.svgicons/package-plus.svgicons/circle-arrow-out-down-left.svg
Preview stroke widths icons/circle-small.svgicons/mars-stroke.svgicons/mars.svgicons/non-binary.svgicons/transgender.svgicons/venus-and-mars.svgicons/venus.svg
icons/circle-small.svgicons/mars-stroke.svgicons/mars.svgicons/non-binary.svgicons/transgender.svgicons/venus-and-mars.svgicons/venus.svg
icons/circle-small.svgicons/mars-stroke.svgicons/mars.svgicons/non-binary.svgicons/transgender.svgicons/venus-and-mars.svgicons/venus.svg
DPI Preview (24px) icons/circle-small.svg icons/mars-stroke.svg icons/mars.svg icons/non-binary.svg icons/transgender.svg icons/venus-and-mars.svg icons/venus.svg
Icon X-rays icons/circle-small.svg icons/mars-stroke.svg icons/mars.svg icons/non-binary.svg icons/transgender.svg icons/venus-and-mars.svg icons/venus.svg
Icon Diffs icons/circle-small.svg icons/mars-stroke.svg icons/mars.svg icons/non-binary.svg icons/transgender.svg icons/venus-and-mars.svg icons/venus.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const CircleSmallIcon = createLucideIcon('CircleSmall', [
  ["circle",{"cx":"12","cy":"12","r":"6"}]
])

const MarsStrokeIcon = createLucideIcon('MarsStroke', [
  ["path",{"d":"m14 6 4 4"}],
  ["path",{"d":"M17 3h4v4"}],
  ["path",{"d":"m21 3-7.75 7.75"}],
  ["circle",{"cx":"9","cy":"15","r":"6"}]
])

const MarsIcon = createLucideIcon('Mars', [
  ["path",{"d":"M16 3h5v5"}],
  ["path",{"d":"m21 3-6.75 6.75"}],
  ["circle",{"cx":"10","cy":"14","r":"6"}]
])

const NonBinaryIcon = createLucideIcon('NonBinary', [
  ["path",{"d":"M12 2v10"}],
  ["path",{"d":"m9 4 6 4"}],
  ["path",{"d":"m9 8 6-4"}],
  ["circle",{"cx":"12","cy":"17","r":"5"}]
])

const TransgenderIcon = createLucideIcon('Transgender', [
  ["path",{"d":"M12 16v6"}],
  ["path",{"d":"M14 20h-4"}],
  ["path",{"d":"M18 2h4v4"}],
  ["path",{"d":"m2 2 7.17 7.17"}],
  ["path",{"d":"M2 5.355V2h3.357"}],
  ["path",{"d":"m22 2-7.17 7.17"}],
  ["path",{"d":"M8 5 5 8"}],
  ["circle",{"cx":"12","cy":"12","r":"4"}]
])

const VenusAndMarsIcon = createLucideIcon('VenusAndMars', [
  ["path",{"d":"M10 20h4"}],
  ["path",{"d":"M12 16v6"}],
  ["path",{"d":"M17 2h4v4"}],
  ["path",{"d":"m21 2-5.46 5.46"}],
  ["circle",{"cx":"12","cy":"11","r":"5"}]
])

const VenusIcon = createLucideIcon('Venus', [
  ["path",{"d":"M12 15v7"}],
  ["path",{"d":"M9 19h6"}],
  ["circle",{"cx":"12","cy":"9","r":"6"}]
])

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 26, 2024
@ericfennis
Copy link
Member

Not sure about adding the neuter icon. I think this one is a bit too specific and I doubt if it will be used that much, I think this one is more for the Lab project to research the use.

@jguddas
Copy link
Member

jguddas commented Jan 6, 2025

Not sure about adding the neuter icon. I think this one is a bit too specific and I doubt if it will be used that much, I think this one is more for the Lab project to research the use.

A use case besides the obvious veterinarian healthcare context would be electrical neutral.

image

@jamiemlaw
Copy link
Contributor Author

Not sure about adding the neuter icon. I think this one is a bit too specific and I doubt if it will be used that much, I think this one is more for the Lab project to research the use.

My main justification for originally including it was that it appeared on the Wikipedia article for gender symbols; and, unlike for the Mercury symbol, gave no indication that it was superseded by something different. I think it is used in botany.

However, I agree that its use case might be more niche than the others, and I'd be happy to get rid of it, knowing we could always add it in later if there is demand for it. Or it could go into `lab'.

Pending additional use cases or significant demand
"jamiemlaw"
],
"tags": [
"gender"
Copy link
Member

@jguddas jguddas Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gender"
"bigender",
"demigender",
"enby",
"gender",
"genderfluid",
"multigender",
"nonbinary",
"pangender",
"plumbus",
"polygender",
"queer",
"sex",
"transexual",
"transfeminine",
"transgender",
"transmasculine",
"two-spirit",
"xenogender"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's getting into the weeds of specific gender identities, which I was hoping to avoid. I can foresee two general problems if we went down that route:

  • Such a list of tags will never be complete and always open to debate.
  • Some of those terms have their own specific icons; a user searching for, say, "pangender" might conclude that we got the icon incorrect, or that we think the symbols are interchangeable.

I'm happy with adding the un-hyphenated "nonbinary" as well as "enby" though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gender icons
3 participants