Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): adds triangle-dashed icon #2652

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Nov 30, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

adds triangle-dashed icon

Icon use case

I maintain an Obsidian drawing tool plugin, simple-sketch.
I'm going to allow users to draw dashed shapes, I can already add tool-buttons for circle and squares but not for triangles.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: triangle
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Copy link

github-actions bot commented Nov 30, 2024

Added or changed icons

icons/triangle-dashed.svg

Preview cohesion icons/square-dashed-bottom-code.svg
icons/triangle-dashed.svg
icons/ticket-percent.svg
Preview stroke widths icons/triangle-dashed.svg
icons/triangle-dashed.svg
icons/triangle-dashed.svg
DPI Preview (24px) icons/triangle-dashed.svg
Icon X-rays icons/triangle-dashed.svg
Icon Diffs icons/triangle-dashed.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const TriangleDashedIcon = createLucideIcon('TriangleDashed', [
  ["path",{"d":"M10.17 4.193a2 2 0 0 1 3.666.013"}],
  ["path",{"d":"M14 21h2"}],
  ["path",{"d":"m15.874 7.743 1 1.732"}],
  ["path",{"d":"m18.849 12.952 1 1.732"}],
  ["path",{"d":"M21.824 18.18a2 2 0 0 1-1.835 2.824"}],
  ["path",{"d":"M4.024 21a2 2 0 0 1-1.839-2.839"}],
  ["path",{"d":"m5.136 12.952-1 1.732"}],
  ["path",{"d":"M8 21h2"}],
  ["path",{"d":"m8.102 7.743-1 1.732"}]
])

@jguddas
Copy link
Member

jguddas commented Dec 2, 2024

You should throw this into https://lucide-studio.vercel.app and press the tidy button.

@Yohh
Copy link
Contributor Author

Yohh commented Dec 2, 2024

You should throw this into https://lucide-studio.vercel.app and press the tidy button.

nice, thank you! it's done

Copy link

github-actions bot commented Jan 3, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 3, 2025
@Yohh
Copy link
Contributor Author

Yohh commented Jan 3, 2025

can anyone remove stale label please?

@Yohh
Copy link
Contributor Author

Yohh commented Jan 3, 2025

thanks @karsa-mistmere , do I need to do anything else for this pr to be merged?

icons/triangle-dashed.svg Outdated Show resolved Hide resolved
@Yohh
Copy link
Contributor Author

Yohh commented Jan 6, 2025

@jguddas thanks for your approval, can I or do I need to update branch? do you prefer merge or rebase?

@jguddas
Copy link
Member

jguddas commented Jan 6, 2025

@jguddas thanks for your approval, can I or do I need to update branch? do you prefer merge or rebase?

@ericfennis is gonna fly by at some point and update + merge this for us, maybe we can also get @karsa-mistmere your approval?

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Yohh !

@Yohh
Copy link
Contributor Author

Yohh commented Jan 6, 2025

thanks @ericfennis , sorry for the bad indent, I didn't see it, you've fixed it before I was ready to push 😆

@ericfennis ericfennis merged commit 389fed8 into lucide-icons:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants