Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --only-ticks-over with async-profiler #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SirYwell
Copy link
Contributor

@SirYwell SirYwell commented Nov 5, 2024

The --only-ticks-over option is extremely useful, but currently causes the profiler to fall back to the Java implementation. This means some insightful information gets lost, e.g. samples during GC pauses or other native frame information.

Supporting the flag with async-profiler isn't exactly straightforward: By default, async-profiler tries to use a CPUs TSC, which makes it difficult to compare times in the JVM. We can force async-profiler to use the Linux monotonic clock, which is the same as the one used by System.nanoTime() (at least in HotSpot). This allows comparing times and filtering out events that occurred outside of a tick that exceeded the threshold.
As events are only processed later, we need to remember the ticks exceeding the threshold temporarily. As events are processed in order, using a queue makes that pretty simple.

This change also allows using the option together with --alloc.

I tried to make the changes as non-intrusive as possible, but maybe there are cleaner ways in some spots. Let me know if you want me to change something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant