Support --only-ticks-over with async-profiler #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--only-ticks-over
option is extremely useful, but currently causes the profiler to fall back to the Java implementation. This means some insightful information gets lost, e.g. samples during GC pauses or other native frame information.Supporting the flag with async-profiler isn't exactly straightforward: By default, async-profiler tries to use a CPUs TSC, which makes it difficult to compare times in the JVM. We can force async-profiler to use the Linux monotonic clock, which is the same as the one used by
System.nanoTime()
(at least in HotSpot). This allows comparing times and filtering out events that occurred outside of a tick that exceeded the threshold.As events are only processed later, we need to remember the ticks exceeding the threshold temporarily. As events are processed in order, using a queue makes that pretty simple.
This change also allows using the option together with
--alloc
.I tried to make the changes as non-intrusive as possible, but maybe there are cleaner ways in some spots. Let me know if you want me to change something.