Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support camelcase when generate migration file, Fix #1045 #1046

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

zw963
Copy link
Contributor

@zw963 zw963 commented May 24, 2024

Test on both CamelCase and underscore form, it should work.

 ╰─ $ lucky gen.migration add_some_column_into_universities
Created AddSomeColumnIntoUniversities::V20240524171815 in ./db/migrations/20240524171815_add_some_column_into_universities.cr
 ╰─ $ lucky gen.migration AddSomeColumnIntoUniversities
Created AddSomeColumnIntoUniversities::V20240524172255 in ./db/migrations/20240524172255_add_some_column_into_universities.cr

BTW: i remove the CamelCase check completely, i consider those code is unnecessary, if a user can user task to create migration, we assume it know how to form the migration name.

@jwoertink jwoertink merged commit c1729f3 into luckyframework:main Jun 16, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants