JSON Support 2

[jwoertink]

This replaces #48 with some updates

• ensure this runs on crystal 0.29.0
• fixes a regression where setting value of anything other than String was ~10x slower
• Puts a type restriction back in place on ColumnDefaultType.

One thing to note about this type restriction is that in pr 48 it was set to Object, this meant you could set default values on json columns super easy like default: {"number" => 1}. That was nice, but it also meant you could set pretty much anything there like default: HTTP::Params since as long as it was of type Object, it would work.

Eventually I would like to open this up, but in keeping with the type safe tradition, we can start with a rough version, and then slowly improve it over time.

[paulcsmith]

This looks really good/close.

I'd love to do another PR that adds some method to the criteria for JSON specific queries! Like contains, looking in keys, etc. That'd be sweet. But can definitely come later :)

[paulcsmith]

Looks great! :D

[paulcsmith]

Actually I just realized I don’t think we have any specs for querying Json. Could you add some specs for stuff like equals?

[paulcsmith]

I don't get notified for updates/force pushes so can you ping me when you're ready for me to take another look?

[jwoertink]

Weird. Yeah, I'm getting ready to work on this now, so it'll be here in a bit.

[jwoertink]

@paulcsmith this adds a simple example on doing a where query with the json. I'll do a new PR to add in fancy query with json.

[paulcsmith]

Looks great! Just needs a rebase and then I'll merge it in!

[jwoertink]

@paulcsmith nothing to rebase.

[paulcsmith]

Hmm looks like there is because I cannot merge

Maybe you need to pull master first?

[jwoertink]

[10:11AM] avram (pr48)$ git checkout master
Switched to branch 'master'
Your branch is ahead of 'origin/master' by 13 commits.
  (use "git push" to publish your local commits)
[10:12AM] avram (master)$ git fetch upstream
[10:12AM] avram (master)$ git merge upstream/master
Already up to date.
[10:12AM] avram (master)$ git checkout pr48
Switched to branch 'pr48'
[10:12AM] avram (pr48)$ git merge master
Already up to date.

I'm not great at git. Maybe I'm missing something?

[paulcsmith]

Ok...maybe GitHub is having issues lol. Because I still see that message that there are conflicts. Can you go ahead and merge it since I can't 🤣