Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_belongs_to uses bigint in AlterTable statements #224

Merged
merged 1 commit into from
Sep 4, 2019
Merged

add_belongs_to uses bigint in AlterTable statements #224

merged 1 commit into from
Sep 4, 2019

Conversation

edwardloveall
Copy link
Member

In #121 we changed our primary keys from Int32 to Int64 but I believe we forgot to update the alter table migration statements to use Int64 as the default primary key type. This causes errors like:

PG::ResultSet#read returned a Int32. A (Int64 | Nil) was expected. (Exception)

or the very similar

PG::ResultSet#read returned a Int32. A Int64 was expected. (Exception)

paulcsmith
paulcsmith approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice catch!

@paulcsmith paulcsmith merged commit 9236380 into master Sep 4, 2019
@paulcsmith paulcsmith deleted the el-alter-table-bigint branch September 4, 2019 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

@jwoertink jwoertink Awaiting requested review from jwoertink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardloveall @paulcsmith