Add compile-time error when passing a raw Hash in to SaveOperation.create/update #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcgarvey
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Looks good. Check out icy-arctic-fox/spectator#15 we might actually be able to test compilation errors
|
oh that's nice. That would be great for us to have something like that. Maybe we use that in a separate shard we can include in all our projects for testing that stuff? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313
A part of the #369 series. This is just an extra development level catch in case you pass a raw hash in to a SaveOperation create or update. I tested this by adding a spec that does it.
On a side note, testing compile-time errors is impossible. I wonder if we should create a spec directory with commented out tests that would be designed for just having a way to make sure they work the way we think... 🤔 it would be a little weird and messy, but something to think about.