Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate migration names #528

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Fix duplicate migration names #528

merged 3 commits into from
Nov 12, 2020

Conversation

shortly-portly
Copy link
Contributor

lucky gen.migrations now returns an error if the migration name already exists.

Fixes issues: #521

Error message is:

    Migration name must be unique

     Migration name: repeat_migration.cr already exists as: 20201112200313_repeat_migration.cr.

Also added tests for the above and for camel case.

jwoertink
jwoertink approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@matthewmcgarvey matthewmcgarvey merged commit 7bd5eec into luckyframework:master Nov 12, 2020
@jwoertink jwoertink mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcgarvey matthewmcgarvey matthewmcgarvey approved these changes

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortly-portly @jwoertink @matthewmcgarvey