Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message when attribute called with type union #583

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Update error message when attribute called with type union #583

merged 1 commit into from
Dec 31, 2020

Conversation

matthewmcgarvey
Copy link
Member

Fixes #466

CleanShot 2020-12-30 at 22 52 51@2x

jwoertink
jwoertink approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is WAY better!

@matthewmcgarvey matthewmcgarvey merged commit 2297d71 into luckyframework:master Dec 31, 2020
@matthewmcgarvey matthewmcgarvey deleted the matthewmcgarvey/issue466 branch December 31, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error when trying to use a nilable attribute
2 participants
@matthewmcgarvey @jwoertink