Support datetime-local time parsing #603
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to close #602.
You can read more about DateTime Local inputs at this link:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local
From what I can gather, browsers basically use RFC 3339 without the timezone. Because of this, our
Time::Format::RFC_3339
parser wasn't actually extracting the time element from adatetime-local
input type in Lucky.PR Components
Time::Format
that will parse thesedatetime-local
inputs correctly, though it will always useTime::Location.local
for the timezone.space_separated_yaml
. Best I can tell, that was added here without any additional details, but it has never actually worked since we didn't have a formatter that matched down to the time element. Without a clear user story, I didn't feel confident adding a custom parser that would allow the new test validations to pass for that format.