Renaming Box to Factory #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoertink
commented
Jan 17, 2021
| getter operation | ||
|
|
||
| SEQUENCES = {} of String => Int32 | ||
|
|
||
| macro inherited | ||
| {% unless @type.abstract? %} | ||
| {% operation = @type.name.gsub(/Box/, "::SaveOperation").id %} | ||
| {% operation = @type.name.gsub(/Factory$/, "::SaveOperation").id %} |
There was a problem hiding this comment.
Added the $ here to ensure it's replacing the ending Factory word in case someone has a model called something like FactorySetting
jwoertink
commented
Jan 17, 2021
Comment on lines
-34
to
-36
| def self.save | ||
| {% raise "'Box.save' has been renamed to 'Box.create' to match 'SaveOperation.create'" %} | ||
| end |
There was a problem hiding this comment.
This has been removed for quite a few versions now, so just getting rid of it instead of fixing the error message.
matthewmcgarvey
approved these changes
Jan 18, 2021
jwoertink
added a commit
that referenced
this pull request
Jan 18, 2021
jwoertink
added a commit
that referenced
this pull request
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
This change renames
Avram::BoxtoAvram::Factory. The main reasons are that the term "Factory" seems to be more common use for this type of object, as well as Crystal already has a built-in Box class.