Changing how the select_count method counts returned rows. #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686
This new way now allows for counting against more complex queries which include using
distinct_on
. The main reason for this is using pagination when you have these complex queries.Before this PR, you couldn't do this:
This would throw an error that
status
needs to be in a "GROUP BY" or used in an aggregate function. But of course, if you addedstatus
to a group, it would also wantid
, and you'd still have to change the count fromCOUNT(*)
toCOUNT(status)
or something else...Also as @wyhaines pointed out in 686, there's several cases where this method is actually faster than the previous. All of the queries I tried seemed to perform about the same speed if not faster.