Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental/json serializable columns #695

Merged
merged 8 commits into from
Jul 18, 2021
Merged

Experimental/json serializable columns #695

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c3d364d
Attempting to implement the json serializable. First spec passes, but…
jwoertink Jul 5, 2021
1daa955
round two reverts some of the previous commit. Now using a column con…
jwoertink Jul 5, 2021
dcbe24b
reverting these changes because they're refactors and not really rela…
jwoertink Jul 5, 2021
29aec80
use separate branch with json changes and we no longer need any patches
jwoertink Jul 5, 2021
75fd177
Adding the ability to query serializable columns
jwoertink Jul 7, 2021
761616f
This line wasn't needed
jwoertink Jul 12, 2021
a34d2f7
Merge branch 'master' into experimental/json_serializable_columns
jwoertink Jul 12, 2021
be1db3c
Go back to original PG Shard, but use master now that Matthew's PR wa…
jwoertink Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion spec/json_column_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe "JSON Columns" do
end

describe "serialized" do
it "saves the raw value" do
it "saves the serialized value" do
SaveBlob.create(metadata: BlobMetadata.from_json("{}")) do |operation, blob|
operation.saved?.should be_true
blob.should_not be_nil
Expand All @@ -80,5 +80,14 @@ describe "JSON Columns" do
blob.not_nil!.media.should be_nil
end
end

it "queries serialized columns" do
one = BlobMetadata.from_json({name: "One", code: 4}.to_json)
two = BlobMetadata.from_json({name: "Two", code: 9}.to_json)
BlobFactory.create &.metadata(one)
BlobFactory.create &.metadata(two)

BlobQuery.new.metadata(two).select_count.should eq(1)
end
end
end
8 changes: 8 additions & 0 deletions src/avram/charms/json_extensions.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,13 @@ module JSON::Serializable
end

module Lucky(T)
alias ColumnType = JSON::Any
jwoertink marked this conversation as resolved.
Show resolved Hide resolved
include Avram::Type

def self.criteria(query : R, column) forall R
Criteria(R, T).new(query, column)
end

def from_db!(value)
value
end
Expand All @@ -23,6 +28,9 @@ module JSON::Serializable
def to_db(value)
value.to_json
end

class Criteria(T, V) < Avram::Criteria(T, V)
end
end
end

Expand Down