Add compile-time catches for common method call mistakes with attributes #738
Conversation
…ttributes but meant to be called on the values. Fixes #731
|
I'm 99% sure the spec failure is a race condition related to #727 |
| # in to string interpolation. Don't override that method. | ||
| def to_s(time_format : String) | ||
| call_value_instead_error_message(".to_s(time_format)") | ||
| end |
There was a problem hiding this comment.
I think these are a great addition. If there's one mistake I make all the time it's calling these methods accidentally.
This specific overload makes me a bit nervous because of the way the name of the string parameter would confuse someone who happened upon this error message through some secondary path that had nothing to do with a time format.
What if the stringified method suggestion in the error message is just .to_s(...) instead? That seems like it would lead people down an almost identical path without lending confusion where they landed here without doing anything with time formats.
There was a problem hiding this comment.
I like that 👍 Makes sense.
|
So today I actually called |
Fixes #731
This doesn't really catch all possibilities, but should catch the bulk of what you might call on your attributes inside of an operation. We found ourselves mainly doing this on JSON attributes..
metadata["key"]?instead ofmetadata.value["key"]?.