Added new default_validations to Operations #751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645
The original issue was that our polymorphic
before_save
callback would run validations before any that you would set in your own SaveOperation. This prevented you from being able to assign your association in your SaveOperation.This PR adds a new functionality to operations (SaveOperation, Operation, and DeleteOperation) to set your own
default_validations
. It works similar tobefore_save
in that it takes a block, and you can run some code in there. When the operations callvalid?
it will run any required validations (as it always has), as well as any default validations you might need. This means you can also abstract them to a module to include them in several different operations if you need.