-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine CRUD templates #935
Conversation
zw963
commented
Mar 30, 2023
- links use non keyword argument form.
- Remove unnecessary namespaces.
I think the namespaces are actually better to have. These help reduce ambiguity when glancing over code, as well as help searching when doing grep across an entire project. It's easier to search for |
Okay, done. |
Wow, this PR not review again since a year ago? |
link "New <%= resource %>", to: <%= pluralized_name %>::New | ||
link "New <%= resource %>", <%= pluralized_name %>::New |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer there to be the to:
. I always add it in my projects. But since line 15 is defined without it, I guess we can do this. Or we need to update line 15 to include the to:
just so they both match.
Sorry, I just forgot to come back to this. It looks like it's behind now though, so it either needs to be updated or closed out. |
Sorry, i push forcefully. i add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change 🙌 It's very clear and consistent. Thank you for adding this.