0.35 support, fixes #29 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AvnerCohen Welcome to Lucky! Thanks so much for giving this a shot. The Lucky team is on a little hiatus this week, but we will try to get to these PRs and get full 0.35 support out this weekend or next week. Sorry you ran in to this, but thanks for your patience 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues working with crystal 0.35.
To be 100% clear, coming from Ruby, this is my first time working with crystal code, hopefully changes makes sense, I also consulted changes from #30 by @bcardiff
(as a side note, got into this as I was trying to play around with lucky, right now this is a blocker to run
shards installon lucky.)