Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lucky project dependency is causing ameba to show up in lib folder #1524

Closed
matthewmcgarvey opened this issue Jun 9, 2021 · 3 comments · Fixed by #1589
Closed

A lucky project dependency is causing ameba to show up in lib folder #1524

matthewmcgarvey opened this issue Jun 9, 2021 · 3 comments · Fixed by #1589
Labels

Comments

@matthewmcgarvey
Copy link
Member

matthewmcgarvey commented Jun 9, 2021

Maybe not a big deal, but I noticed in my project I generated with lucky cli that ameba is showing up in the lib/ folder even though it's not a dependency and is not a transitive dependency either. When I run shards prune it is removed but added back as soon as I run shards install again.

CleanShot 2021-06-08 at 20 28 01@2x

@jwoertink
Copy link
Member

Weird... Would this be a shards bug? Or maybe all development dependencies always show up in lib unless you do shards install --production?

@jwoertink
Copy link
Member

Looking in to this, it turns out it's Avram... Though, I'm still not sure why. Removed Avram from the list, and it doesn't show up. Ameba is a dev dependency of Avram, but it's also a dev dependency of ALL the Lucky shards. i created a new project with just Avram, and Ameba shows up. Then I made a project with just Habitat, and it doesn't show up....

@jwoertink
Copy link
Member

Found the issue. Turns out this also exists in Lucky, and Carbon. The issue is that when the postinstall runs for each of these shards, it calls shards build from those directories. That will run a shards install within that directory which includes development dependencies.

To fix this, we need to add --without-development to each of these shards build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants