Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ameba from being installed during postinstall #1589

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1524

Description

When Lucky is included as a dependency of an app, and you run shards install, it will call Lucky's postinstall script. That will then run shards build from within the lucky directory causing it to install all shards including development dependencies.

This PR tells it to only build the targets, but don't build development dependencies.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

@jwoertink jwoertink merged commit f01fd5e into master Oct 2, 2021
@jwoertink jwoertink deleted the issues/precompile_shards branch October 2, 2021 22:43
shards build
else
shards build --without-development
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the typical use case here would be to build without development, should this if be reversed so that the flag doesn't need to be passed in unless you actually want the ancillary binaries?

Do we even need the flag here? Assuming that I actually want the ameba binary I can add that to my own shards.build stanza for the project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bash skills suck 😅 it should probably be flipped

@edwardloveall and I were talking about this, and we figured if you're working on Lucky directly, maybe there's a time you want to run that script with any dev deps included? I think the 99% case though would be without.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lucky project dependency is causing ameba to show up in lib folder
2 participants