Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "spinner" to watch task when compiling, or recompiling #1606

Closed
jwoertink opened this issue Nov 3, 2021 · 4 comments · Fixed by #1653
Closed

Add "spinner" to watch task when compiling, or recompiling #1606

jwoertink opened this issue Nov 3, 2021 · 4 comments · Fixed by #1653

Comments

@jwoertink
Copy link
Member

Related: #1067
Related: luckyframework/lucky_cli#481

When we start compiling tasks, we show a "spinner" in the console. It's neat, and adds a little flare while you're sitting there waiting.

Right now when we run the lucky watch task, between compiles, you'll either see "Compiling..." or "Recompiling..." but no spinner. Having the spinner would allow it to stand out a little more within the mess that is the Process manager output..

@skojin
Copy link
Contributor

skojin commented Jan 19, 2022

Since spinner not working with overmind (#1067),
I suggest add newline before "Compiling..."
And make "Done" in "Done compiling" colored like in #1067 (comment)

@jwoertink
Copy link
Member Author

oh, the next release of Lucky won't use Overmind anymore (unless you specifically want it to). luckyframework/lucky_cli#710 I don't mind the suggestion as an interim, but since we already use the spinner when building tasks and such, I'd love to keep the consistency. I'd like to try it out with Nox and see if it works first. If not, then we will definitely fallback to your suggestion 👍

@skojin
Copy link
Contributor

skojin commented Jan 19, 2022

Nox not work with spinner too.

e.g. with default Procfile that have lucky db.migrate

nox start Compiling... appear at end

release | Starting with pid of 2495
release | Did not migrate anything because there are no pending migrations.
Compiling... ⢿

release | Done

@jwoertink
Copy link
Member Author

Ah... well that's a bummer 😂 Thanks so much for giving it a shot! In that case, I think #1067 (comment) is the next best solution. It'll bring a bit more attention to what's going on when there's a lot of other activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants