Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number_to_currency still writes to IO #790

Closed
jwoertink opened this issue Jun 5, 2019 · 1 comment · Fixed by #809
Closed

number_to_currency still writes to IO #790

jwoertink opened this issue Jun 5, 2019 · 1 comment · Fixed by #809
Labels

Comments

@jwoertink
Copy link
Member

this PR changed a few of the text helpers to return a string as opposed to writing directly to the view IO. The rule is that if the method returns HTML, it should render directly to the view, and if it only returns a plain string, then the method should just return the string.

Looks like number_to_currency is still calling text which renders to the view IO, but there's no reason (that I can see) that it should.

@paulcsmith
Copy link
Member

Yeah that should return a string. Good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants