You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this PR changed a few of the text helpers to return a string as opposed to writing directly to the view IO. The rule is that if the method returns HTML, it should render directly to the view, and if it only returns a plain string, then the method should just return the string.
Looks like number_to_currency is still calling text which renders to the view IO, but there's no reason (that I can see) that it should.
The text was updated successfully, but these errors were encountered:
this PR changed a few of the text helpers to return a string as opposed to writing directly to the view IO. The rule is that if the method returns HTML, it should render directly to the view, and if it only returns a plain string, then the method should just return the string.
Looks like number_to_currency is still calling
text
which renders to the view IO, but there's no reason (that I can see) that it should.The text was updated successfully, but these errors were encountered: