Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number_to_currency now returns a String instead of writing to the view #809

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Conversation

jwoertink
Copy link
Member

Purpose

fixes #790

Description

In a recent PR, most of the page helpers were converted to return a String instead of writing to the view via text. The rule is now if the method generates HTML, it writes to the view, otherwise it should return a String. This method was missed during that commit.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Specs pass when settings avram back to 0.9.4. Since Avram renamed Field and Form stuff recently, and Lucky pulls from Avram master, specs fail.

@edwardloveall
Copy link
Member

This is all fine, lucky just needs to be updated: #810

@paulcsmith paulcsmith merged commit 9ddb4dd into luckyframework:master Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number_to_currency still writes to IO
3 participants