New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also print where a component finished rendering #793

Closed

paulcsmith opened this issue Jun 7, 2019 · 0 comments · Fixed by #817

Labels

easy/high impact

Milestone

Member

paulcsmith commented Jun 7, 2019 •

edited

Loading

When rendering a component it prints some debug info

lucky/src/lucky/mount_component.cr

Line 16 in f6d4b97

raw ""

It should also show “Finished: MyComponent” so it is clear where it ends. The “rendered by” line should change to “Started: My Component”

jwoertink added the easy/high impact label

paulcsmith modified the milestones: Lucky next (stretch goals), Lucky next

jwoertink mentioned this issue

Added finishing comment to mounted components. #817

Merged

5 tasks

paulcsmith closed this as completed in #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment