Added finishing comment to mounted components. #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcsmith
reviewed
Jun 19, 2019
| @@ -1,19 +1,46 @@ | |||
| module Lucky::MountComponent | |||
| # Appends the `component` to the view. | |||
| # | |||
| # When `Lucky::HTMLPage.settings.render_component_comments` is | |||
There was a problem hiding this comment.
Maybe: "When Lucky::HTMLPage.settings.render_component_comments is set to true" Since that is what the user will set. They won't know about the private method
There was a problem hiding this comment.
That's what it says now though... 🤔
There was a problem hiding this comment.
Just testing you. You passed 🤣LOL
|
Looks good. Pretend I never commented haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fixes #793
Description
This adds an additional ending HTML comment to show where the mounted components both start and end.
Checklist
crystal tool format spec src./script/setup./script/test