-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how we handle Accepts and Content-Type #822
Milestone
Comments
paulcsmith
added a commit
that referenced
this issue
Aug 9, 2019
Closed
paulcsmith
added a commit
that referenced
this issue
Aug 10, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 10, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 10, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 11, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 12, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 12, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 12, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 12, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 12, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 12, 2019
paulcsmith
added a commit
that referenced
this issue
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now the param parser correctly parses the Content-Type
lucky/src/lucky/params.cr
Lines 384 to 394 in b5d6056
But when check what the request wants in return we incorrectly use Content-Type but we should instead use
Accept
.I think we can keep the same
html?|json?|etc
methods, but they should all use theAccept
header instead ofContent-Type
Prior art
The text was updated successfully, but these errors were encountered: