Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming a few things for clarity #1006

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Renaming a few things for clarity #1006

merged 1 commit into from
Feb 10, 2020

Conversation

jwoertink
Copy link
Member

Follow up to #997

paulcsmith
paulcsmith approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good! Thanks

Also did you create a PR for checking for chromedriver? I swear I saw something in my email about it but now I can’t find anything. Maybe I just misread

@paulcsmith paulcsmith merged commit 802cdfd into master Feb 10, 2020
@paulcsmith paulcsmith deleted the jaw/995v2 branch February 10, 2020 23:45
@jwoertink
Copy link
Member Author

Maybe it was related to this: #1002 ? also #953

@paulcsmith
Copy link
Member

paulcsmith commented Feb 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwoertink @paulcsmith