[Breaking change] generate getters for needs in pages #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #853 The breaking change is that you can't use ? in 'needs' anymore. Instead we generate a 'getter?' if the type is a Bool. Also we may overwrite a method by generating a getter but I think there is very little change since most methods would be defined *after* needs
paulcsmith
force-pushed
the
pcs/853/getters
branch
from
d9a298f
to
dc80fdf
Compare
paulcsmith
changed the title
paulcsmith
force-pushed
the
pcs/853/getters
branch
from
7b8f530
to
7ea9dcc
Compare
paulcsmith
force-pushed
the
pcs/853/getters
branch
from
7ea9dcc
to
9954b32
Compare
|
wow! This is awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #853
The breaking change is that you can't use ? in 'needs' anymore. Also we
may overwrite a method by generating a getter but I think there is very
little change since most methods would be defined after needs