Input error -> Clarify problem and solution. Add module for showing error with Shared::Field #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkthorne
approved these changes
Mar 18, 2020
paulcsmith
changed the title
paulcsmith
added a commit
to luckyframework/lucky_cli
that referenced
this pull request
Mar 18, 2020
This error always happened when calling the input/label methods, but if you used the Shared::Field component you'd get a generic "no overload matches". This module added in luckyframework/lucky#1052 makes it so you get the same nice error in field components. This greatly improves the ease of use and DX when using Lucky.
paulcsmith
added a commit
to luckyframework/lucky_cli
that referenced
this pull request
Mar 18, 2020
This error always happened when calling the input/label methods, but if you used the Shared::Field component you'd get a generic "no overload matches". This module added in luckyframework/lucky#1052 makes it so you get the same nice error in field components. This greatly improves the ease of use and DX when using Lucky.
paulcsmith
added a commit
to luckyframework/lucky_cli
that referenced
this pull request
Apr 7, 2020
This error always happened when calling the input/label methods, but if you used the Shared::Field component you'd get a generic "no overload matches". This module added in luckyframework/lucky#1052 makes it so you get the same nice error in field components. This greatly improves the ease of use and DX when using Lucky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.