Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove changed file log #1065

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Remove changed file log #1065

merged 1 commit into from
Mar 26, 2020

Conversation

paulcsmith
Copy link
Member

I've never seen this and thought "Oh yeah I did change that file!"

I think we can just remove it so there is less noise in the log

@paulcsmith
Remove changed file log
7981720 
I've never seen this and thought "Oh yeah I did change that file!"

I think we can just remove it so there is less noise in the log
jwoertink
jwoertink approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen the new compiler message yet, but as long as it lets you know, I think this is fine.

@paulcsmith
Copy link
Member Author

It still lets you know it’s compiling. This just removes the part that says what file changes in yellow. Is that what you meant?

@jwoertink
Copy link
Member

Yup, exactly.

@paulcsmith
Copy link
Member Author

Perfect!

@paulcsmith paulcsmith merged commit 7307e19 into master Mar 26, 2020
@paulcsmith paulcsmith deleted the pcs/remove-useless-logs branch March 26, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulcsmith @jwoertink