Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if you try to generate a model that already exists #1127

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1008

Description

For those sleepy late programming moments!

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it! Just one suggestion

tasks/gen/model.cr Outdated Show resolved Hide resolved
jwoertink and others added 2 commits April 29, 2020 13:28
Co-Authored-By: Paul Smith <paulcsmith@users.noreply.github.com>
@paulcsmith paulcsmith merged commit 6352349 into master Apr 30, 2020
@paulcsmith paulcsmith deleted the errors/1008 branch April 30, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running gen.model multiple times, generates multiple migrations.
2 participants