Fixing bug with generated pages #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d have the path and not the variable. Fixes #1110
|
I'm going to merge this in since people are starting to run in to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1110
Description
The
@output_pathwas using string interpolation, but since it's coming from the template, it should be an ECR tag. I'm not sure if we have a way to check this, but this looks more correct 😅On a side note, I couldn't run specs because I was getting issues with Dexter. I updated the versions since these are released now to get specs to run locally.
Checklist
crystal tool format spec src./script/setup./script/test