Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set default status to nil in send_text_resonse. #1214

Merged
merged 1 commit into from Jul 1, 2020
Merged

Fix: set default status to nil in send_text_resonse. #1214

merged 1 commit into from Jul 1, 2020

Conversation

wout
Copy link
Contributor

@wout wout commented Jul 1, 2020

Purpose

FIxes #1213

Description

I'm sorry for the inconvenience. :)

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

jwoertink
jwoertink approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 thanks!

@jwoertink jwoertink merged commit bb92bb2 into luckyframework:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send_text_response returns a 100 by default which can break some apps
2 participants
@wout @jwoertink