Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the UrlHelpers include in to the HTMLBuilder #1228

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Adding the UrlHelpers include in to the HTMLBuilder #1228

merged 1 commit into from
Jul 30, 2020

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1218

Description

Both pages and components include the Lucky::HTMLBuilder module. By including the UrlHelpers here, current_page? will be available in both pages and components. Before this you had to manually include the UrlHelpers to use the current_page? method.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

paulcsmith
paulcsmith approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jwoertink jwoertink merged commit 29188da into master Jul 30, 2020
@jwoertink jwoertink deleted the issues/1218 branch July 30, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcsmith paulcsmith paulcsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UrlHelpers should be included in components as well
2 participants
@jwoertink @paulcsmith