Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the Memoizable module to Object. Fixes #1253 #1270

Merged
merged 5 commits into from
Oct 13, 2020
Merged

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1253
Fixes #1095

Description

By including this module in to Object directly, we no longer need to include it in each class we want to use. This will allow us to use it in component, pages, actions, and more out of the box.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a formatting issue but overall this looks good!

src/charms/object.cr Outdated Show resolved Hide resolved
jwoertink and others added 3 commits October 13, 2020 09:59
@jwoertink jwoertink merged commit 078b432 into master Oct 13, 2020
@jwoertink jwoertink deleted the issues/1253 branch October 13, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include Lucky::Memoizable in Object so it usable everywhere Move memoize macro to Object
2 participants