Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the name variable on custom tags to tag_name. #1309

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Conversation

jwoertink
Copy link
Member

Purpose

Fixes #1307

Description

If you're building a front-end app and need your custom tags to take a name prop, this would conflict with the custom tag's name argument.

tag("widget", name: "Alert")

#=> Error: argument 'name' already specified

This PR fixes it by changing the argument to tag_name.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

…s name attributes to the tag without conflicting on what it's going to generate. Fixes #1307
@jwoertink jwoertink merged commit 0635f76 into master Nov 14, 2020
@jwoertink jwoertink deleted the issues/1307 branch November 14, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Funny no overload matches error
2 participants