Use HTTP::Status description for logging #1362

matthewmcgarvey · 2020-12-15T01:11:19Z

Purpose

Fixes #1306

We were logging out an enum, but that enum has a description method that gives us a more human readable message.

- An issue already exists detailing the issue/or feature request that this PR fixes
- All specs are formatted with crystal tool format spec src
- Inline documentation has been added and/or updated
- Lucky builds on docker with ./script/setup
- All builds and specs pass on docker with ./script/test

It was needed when we were passing in an enum, but now it won't be doing anything useful.

jwoertink

nice!

matthewmcgarvey added 2 commits December 14, 2020 19:05

Use HTTP::Status description for logging

4fd27a8

Remove humanize from status description

6fb0f33

It was needed when we were passing in an enum, but now it won't be doing anything useful.

jwoertink approved these changes Dec 15, 2020

View reviewed changes

jwoertink merged commit 3a0bab4 into luckyframework:master Dec 15, 2020

matthewmcgarvey deleted the fix-status-logging branch December 15, 2020 03:13