Moving params in to HTTP::Server::Context #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context is, and ensures we only parse once per request. Fixes #1473
jwoertink
commented
May 28, 2021
| @@ -4,6 +4,7 @@ abstract class Lucky::Action | |||
| getter :context, :route_params | |||
|
|
|||
| def initialize(@context : HTTP::Server::Context, @route_params : Hash(String, String)) | |||
| context.params.route_params = @route_params | |||
There was a problem hiding this comment.
It feels weird putting this here, but where else would it go?
jwoertink
commented
May 28, 2021
Comment on lines
+2
to
4
| memoize def params : Lucky::Params | ||
| context.params | ||
| end |
There was a problem hiding this comment.
This is basically just so you can still call params in your actions without having to call context.params.
jwoertink
commented
May 28, 2021
|
|
||
| @_params : Lucky::Params? | ||
|
|
||
| def params : Lucky::Params |
There was a problem hiding this comment.
Side bonus, params is now available in all Components thanks to #1488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1473
This is my stab at solving #1473
Description
The original issue was that we were instantiating the params object twice. This lets us do it just once by moving it in to context.
The only strange thing I'm not too sure on is the whole part of setting
route_paramslater. I don't think it affects anything here, but I for sure want another set of eyes on this one.Checklist
crystal tool format spec src./script/setup./script/test